Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme tests and CLI each modeled CSS parsing and cascade rules, while the first-paint bootstrap maintained another copy of the theme map. Both color parsers accepted mixed RGB syntax that Chromium rejects. Validation also exposed a runtime Google Fonts import that can reject Vite's CSS preload and prevent the desktop renderer from starting offline.
This PR uses Chromium computed styles with one contrast/report engine, preserving the union of every existing theme threshold, editorial surface/button checks, high-contrast requirements, and CVD separation. Vite now embeds the canonical theme map and defaults directly into the synchronous bootstrap in development and production. It also fixes the invalid color declarations and uses existing local/system font fallbacks without a runtime font CDN.
The duplicate parser and source-regex suites are removed. CI runs the unified contrast gate and appearance browser journeys. The latter now verifies all 27 themes before React can load, authoritative snapshot precedence over conflicting cached settings, startup with Google Fonts blocked, live window/terminal/diff theme updates, and Fixed appearance behavior. Its obsolete combined-diff fixture is updated to the current manifest/file API.
Validation:
pnpm lintandpnpm typecheckwith pinned pnpm 10.19.0.pnpm build:frontend, including xterm request-mode and production React Scan verifiers.--allretains report-only behavior.No dependencies or supply-chain exceptions are added.
Closes #625
Closes #626
Closes #631
Closes #635